Re: Basic info needed regarding filters (FIR)
- From: John Larkin <jjlarkin@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
- Date: Sat, 24 Nov 2007 09:07:35 -0800
On Sat, 24 Nov 2007 08:20:13 -0600, "Vladimir Vassilevsky"
<antispam_bogus@xxxxxxxxxxx> wrote:
"John Larkin" <jjlarkin@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote in message
news:ngkek35vfm4oob6slhsh0nrs2bm5dma4jk@xxxxxxxxxx
On Fri, 23 Nov 2007 12:43:10 -0600, Vladimir Vassilevsky
<antispam_bogus@xxxxxxxxxxx> wrote:
Here is the basic realpole filter which is simpler and appears to have
almost identical response:
const u8 order = 4;
s32 LPF(s32 x)
{
static s32 z[order];
for(u8 i = 0; i < order; i++) x = z[i]+= (x - z[i])>>6;
return x;
}
Making digital filter as the simulation of an analog filter is rarely a
good idea.
I've sold over 3000 of the temperature controllers that use this
filter.
McDonalds serves somewhat 10 billion meals per year. But this fact doesn't
make those meals taste any better or worse :)
Selling things for high prices to high-end customers, in volume, for
years, bug-free, means we're doing exactly what we want to do. Any
other criterion for engineering quality is, literally, academic.
So why is it not a good idea? Why so dogmatic?
More important, my filter has comments and yours doesn't.
I am sorry if you didn't understand 3 lines of trivial C code without
comments. It would be a good idea to do some learning before suggesting the
advanced digital filter topologies...
VLV
I've made a solemn vow to never code in C. But comments don't explain
code, comments explain what code is for and what it does. Your filter
is just a heap of code. I have no idea what it's response is like, and
would have to analyze or simulate it to determine that.
So, what is its frequency response?
John
.
- Follow-Ups:
- Re: Basic info needed regarding filters (FIR)
- From: Nobody
- Re: Basic info needed regarding filters (FIR)
- From: Vladimir Vassilevsky
- Re: Basic info needed regarding filters (FIR)
- From: Jan Panteltje
- Re: Basic info needed regarding filters (FIR)
- References:
- Basic info needed regarding filters (FIR)
- From: faizankhan666@xxxxxxxxx
- Re: Basic info needed regarding filters (FIR)
- From: John Larkin
- Re: Basic info needed regarding filters (FIR)
- From: Tim Wescott
- Re: Basic info needed regarding filters (FIR)
- From: John Larkin
- Re: Basic info needed regarding filters (FIR)
- From: Vladimir Vassilevsky
- Re: Basic info needed regarding filters (FIR)
- From: John Larkin
- Re: Basic info needed regarding filters (FIR)
- From: Vladimir Vassilevsky
- Re: Basic info needed regarding filters (FIR)
- From: John Larkin
- Re: Basic info needed regarding filters (FIR)
- From: Vladimir Vassilevsky
- Basic info needed regarding filters (FIR)
- Prev by Date: Re: SED Posts in the Wild
- Next by Date: Re: Basic info needed regarding filters (FIR)
- Previous by thread: Re: Basic info needed regarding filters (FIR)
- Next by thread: Re: Basic info needed regarding filters (FIR)
- Index(es):
Relevant Pages
|